aglinxinyuan opened a new pull request, #6878:
URL: https://github.com/apache/texera/pull/6878

   ### What changes were proposed in this PR?
   
   Adds `AsterixDBSourceOpExecSpec` (47 tests) for a file that had **0% 
coverage**. The class builds SQL++ strings (no JDBC), so the tests drive the 
string-building surface directly:
   - `addFilterConditions` and each branch it dispatches to — 
`addKeywordSearch` (ftcontains; `IllegalArgumentException` on a non-STRING 
column), `addRegexSearch` (regexp_contains), `addGeoSearch` (create_rectangle 
for 2 corners, create_polygon for more, OR-joined spatial_intersect per column, 
`NumberFormatException` on a malformed point), and `addGeneralFilterCondition`;
   - the skip paths for every toggle-off / missing-input case, and the composed 
keyword→regex→geo→general ordering;
   - schema derivation from the AsterixDB datatype, and the 
base-select/limit/offset fragments.
   
   Also narrows `AsterixDBConnUtilSpec`'s teardown of the JVM-wide 
`AsterixDBConnUtil.asterixDBVersionMapping` singleton to its own keys instead 
of `clear()`: sbt runs suites in parallel within one JVM, so a blanket 
`clear()` can evict the new suite's cached entry mid-run. Both suites verified 
together. No source changes.
   
   ### Any related issues, documentation, discussions?
   
   Closes #6875.
   
   ### How was this PR tested?
   
   `sbt -java-home <jbr-17> "WorkflowOperator/testOnly 
*AsterixDBSourceOpExecSpec"` -> 47 succeeded, 0 failed; both AsterixDB suites 
together -> 84 succeeded, 0 failed. `Test/scalafmtCheck` + `Test/scalafix 
--check` clean.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to