VuMartin opened a new pull request, #6894:
URL: https://github.com/apache/texera/pull/6894

   ### What changes were proposed in this PR?
   
   Fixed the FilledAreaPlot validation logic for grouped data with shared 
X-values.
   
   ```diff
   - X_values = x_values.union(set(group[$x].unique()))
   + x_values = x_values.union(set(group[$x].unique()))
   
   Previously, the validation incorrectly handled X-value comparisons between 
groups, causing valid charts to be rejected. The logic was updated so that 
X-values are tracked across groups correctly when checking whether groups share 
compatible X attributes.
   
   Before: 
   <img width="1197" height="684" alt="Screenshot 2026-07-23 at 2 42 16 AM" 
src="https://github.com/user-attachments/assets/51936cc6-a207-4afd-94e4-a0206db651ba";
 />
   
   After:
   <img width="1198" height="601" alt="Screenshot 2026-07-25 at 2 17 10 AM" 
src="https://github.com/user-attachments/assets/50dbb422-cad3-4623-92c8-ba5c7ca79dde";
 />
   
   
   ### Any related issues, documentation, discussions?
   
   Fixes #6728
   
   ### How was this PR tested?
   
   Tested by running Texera locally and executing a FilledAreaPlot workflow 
with grouped data.
   CSV File:
   
[filled_area_test.csv](https://github.com/user-attachments/files/30370844/filled_area_test.csv)
   
   Verified:
   - Valid grouped charts are accepted and rendered.
   - Invalid inputs missing X/Y attributes still return the appropriate error 
message.
   - Python UDF execution works after generating Python proto bindings and 
installing required Python dependencies.
   
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: ChatGPT (GPT-5.5-mini)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to