Yicong-Huang commented on code in PR #5737:
URL: https://github.com/apache/texera/pull/5737#discussion_r3677551694
##########
amber/src/main/scala/org/apache/texera/amber/engine/architecture/scheduling/RegionExecutionCoordinator.scala:
##########
@@ -64,6 +64,15 @@ import java.util.concurrent.TimeUnit
import java.util.concurrent.atomic.AtomicReference
import scala.concurrent.duration.{Duration => ScalaDuration}
+object RegionExecutionCoordinator {
+
+ // Max EndWorker retries before termination fails. ~30s at
DefaultKillRetryDelay (200ms).
+ private[scheduling] val DefaultMaxTerminationAttempts: Int = 150
+
+ private[scheduling] val DefaultKillRetryDelay: TwitterDuration =
+ TwitterDuration.fromMilliseconds(200)
+}
Review Comment:
this number is too large! why does it need to retry for 150 times to kill a
worker? this uptime to 30s per worker. in integration tests this will easily
rocket up.
Example:
https://github.com/apache/texera/actions/runs/30479437487/job/90673007976?pr=7042
Can we change this to 3 retries max?
At the end of day, we should fix the flakiness, there shouldn't be retries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
