Yicong-Huang commented on PR #7112: URL: https://github.com/apache/texera/pull/7112#issuecomment-5126542997
Closing after a second look: despite the `fix(` prefix, #6402 is substantively a feature, not a bug fix, and shouldn't ride onto a release branch. It adds a new required `email` field to the Sign Up flow (a UI field that didn't exist), changes the `UserRegistrationRequest` API contract from `(username, password)` to `(username, email, password)` — a breaking change for v1.2 clients — and adds new email format/uniqueness validation. v1.2's current registration (email defaults to username) works as-is; this would change release-line behavior rather than fix a regression/crash/security issue. If capturing a real email at registration is wanted on v1.2, it should go in as a deliberate, reviewed change, not an automatic backport. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
