kz930 commented on code in PR #7258:
URL: https://github.com/apache/texera/pull/7258#discussion_r3716603715
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/visualization/timeSeriesplot/TimeSeriesOpDesc.scala:
##########
@@ -30,6 +30,19 @@ import
org.apache.texera.amber.operator.metadata.{OperatorGroupConstants, Operat
import javax.validation.constraints.{NotBlank, NotNull}
+// type constraint: the time axis is an instant and the plotted value is a
measurement.
+// Neither is enforced today: a non-time column is coerced with
errors='coerce', so
+// every row becomes NaT and the dropna that follows reports an empty table
without
+// naming the cause, and a text value column silently degenerates the y axis
into a
+// categorical one.
+@JsonSchemaInject(json = """
+{
+ "attributeTypeRules": {
+ "timeColumn": { "enum": ["timestamp"] },
Review Comment:
Fixed in 41f2b13 — the rule is now ["timestamp", "string"], and the spec
reads both rules back out of the generated schema plus pins that unparseable
text is coerced, dropped and reported rather than raised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
