aglinxinyuan opened a new issue, #7440:
URL: https://github.com/apache/texera/issues/7440

   ### Task Summary
   
   Whether `UserDatasetListItemComponent` offers any editing is decided in the 
template by **two** conditions rather than one:
   
   ```html
   *ngIf="editable && entry.accessPrivilege === 'WRITE'"
   ```
   
   The list being editable is not on its own permission to change someone 
else's dataset, and a writer on a non-editable list should not be offered 
controls either. The same pair guards the inline description:
   
   ```html
   (click)="editingDescription = editable && entry.accessPrivilege === 'WRITE'"
   ```
   
   The existing suite exercises the component's methods and never renders, so 
neither half of either gate is pinned. Both should be tested independently — 
dropping either one alone still leaves a passing single-condition test.
   
   Also unpinned: the owner and shared-access markers being mutually exclusive 
(showing both would tell an owner their own dataset had been shared with them), 
the shared marker interpolating the privilege actually held, and the rename 
input being seeded from the dataset's name rather than its description.
   
   Note: ng-zorro consumes the `nz-tooltip` attribute and interpolated titles 
never reach the DOM, so locate these markers through `NzTooltipDirective` and 
read `directiveTitle`.
   
   ### Task Type
   
   - [ ] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [x] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to