aglinxinyuan opened a new pull request, #7452:
URL: https://github.com/apache/texera/pull/7452
### What changes were proposed in this PR?
Deletes `EmptyReplayLogger`, a no-op `ReplayLogger` that the log-replay
factory no longer reaches. Pure deletion, no behaviour change: **−171 lines**.
| Removed | Lines | Why it is dead |
| --- | ---: | --- |
| `engine/architecture/logreplay/EmptyReplayLogger.scala` | 41 | never
instantiated |
| `engine/architecture/logreplay/EmptyReplayLoggerSpec.scala` | 130 | covers
only the above |
The null-object role moved up a layer to `EmptyReplayLogManagerImpl`, which
implements the no-ops inline:
```
ReplayLogManager.scala:51 -> EmptyReplayLogManagerImpl (inline no-ops,
live)
ReplayLogManager.scala:109 -> new ReplayLoggerImpl() (the only
ReplayLogger built in main)
EmptyReplayLogger (never
instantiated)
```
No configuration selects a logger class by name, so there is no path that
revives it.
> Reviewer note: the abstract base `ReplayLogger` is **not** touched —
`ReplayLoggerImpl` extends it and is unaffected. `EmptyReplayLogger` acquired
unit tests during the 2026 coverage work, which is why it currently looks live;
the spec covers this class and nothing else.
Split out of #7447, which originally bundled four unrelated removals.
### Any related issues, documentation, discussions?
Closes #7449
### How was this PR tested?
Existing tests only — this PR adds none, since it removes code and the spec
that covered it.
Locally, from the repo root with Java 17:
- `sbt "WorkflowExecutionService/Test/compile"` — success.
Verification, re-runnable by a reviewer:
```
git grep -n EmptyReplayLogger # only the two
deleted files
git grep -n "extends ReplayLogger" -- amber/src/main # ReplayLoggerImpl
remains
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
