mengw15 opened a new pull request, #7471:
URL: https://github.com/apache/texera/pull/7471
### What changes were proposed in this PR?
Extends `time-travel.component.spec.ts` to render the execution table. The
class
was already ~92% covered but the template sat at ~42% — the existing tests
call
the class methods directly and never render a row. Adds 6 DOM-driven tests:
- **Rows** — one `<tr>` per execution with its eid cell and a starting-time
cell;
no execution rows when the list is empty.
- **Expand / collapse** — clicking a row expands the `*ngIf` detail row and a
second click collapses it.
- **Interaction list** — the expanded row renders one button per entry of
`interactionHistories[eId]` with its label.
- **Click wiring** — an interaction button passes the row's `vId`/`eId` and
the
interaction to `onInteractionClick`.
- **Disabled binding** — only the interaction already reverted to is
disabled.
This takes the template from 8/19 to **19/19 instrumented lines (100%)**.
Per the issue's determinism note the starting-time cell is rendered but its
formatted text is not asserted (it is timezone-dependent); the test only
checks
the pipe produced output. Execution rows are counted by their two data cells
rather than a raw `tbody tr` count, so the nz-table empty placeholder and the
colspan detail row don't skew the count. No production code was changed.
### Any related issues, documentation, discussions?
Closes #7468.
### How was this PR tested?
`ng test --watch=false --include
src/app/workspace/component/left-panel/time-travel/time-travel.component.spec.ts`
— 18 passed (12 existing + 6 new). Template coverage confirmed at 19/19 lines
via the lcov report. `eslint` and `prettier --check` clean. Failure path
verified by breaking a new assertion (→ non-zero exit) and restoring.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
