Yicong-Huang commented on code in PR #7427: URL: https://github.com/apache/texera/pull/7427#discussion_r3744414065
########## CONTRIBUTING.md: ########## @@ -54,6 +54,37 @@ Thank you for your interest in contributing to Texera! Please follow the steps b - `fix(ui): prevent racing of requests` - `chore(deps): bump numpy to version 2.0.0` +##### Choosing between `feat`, `fix`, and `refactor` + +The type depends on what happens to the behavior, not on how large the change is. + +| Your change | Type | +| ----------- | ---- | +| A functionality worked before and no longer does | `fix` | +| A functionality or a form of support never existed and you are adding it | `feat` | Review Comment: It should be a `feat`. Behavior is defined by the code. If a feature has never existed in the codebase, then it does not exist, even if a PR description or documentation says otherwise. Implementing that behavior is therefore introducing a new feature. Issues like this happen when reviewers do not verify PR descriptions and documentation against the actual code. I hope AI-assisted reviews will help us catch these inconsistencies and reduce cases where features are documented as existing but do not actually exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
