Neilk1021 commented on code in PR #7055:
URL: https://github.com/apache/texera/pull/7055#discussion_r3746515342
##########
amber/src/main/scala/org/apache/texera/web/resource/auth/AuthResource.scala:
##########
@@ -95,21 +99,33 @@ object AuthResource {
)
}
- def createAdminUser(): Unit = {
- val adminUsername = UserSystemConfig.adminUsername
- val adminPassword = UserSystemConfig.adminPassword
+ def createAdminUser(): Unit =
+ createAdminUser(UserSystemConfig.adminUsername.trim,
UserSystemConfig.adminPassword.trim)
- if (adminUsername.trim.nonEmpty && adminPassword.trim.nonEmpty) {
- val existingUser = userDao.fetchByName(adminUsername)
- if (existingUser.isEmpty) {
- val user = new User
- user.setName(adminUsername)
- user.setEmail(adminUsername)
- user.setRole(UserRoleEnum.ADMIN)
- user.setPassword(new
StrongPasswordEncryptor().encryptPassword(adminPassword))
- userDao.insert(user)
- }
+ /**
+ * Bootstrap the configured admin account, doing nothing if it already
exists. The credentials
+ * are parameters rather than reads of [[UserSystemConfig]] because those
are object vals
+ * resolved once per JVM, which leaves the unconfigured case unreachable
from a test.
+ */
+ private[auth] def createAdminUser(adminUsername: String, adminPassword:
String): Unit = {
Review Comment:
another case of it being valid but I think more appropriate for a git issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
