zyratlo commented on code in PR #7392:
URL: https://github.com/apache/texera/pull/7392#discussion_r3753796847
##########
frontend/src/app/workspace/component/menu/menu.component.ts:
##########
@@ -999,7 +999,22 @@ export class MenuComponent implements OnInit, OnDestroy {
this.workflowActionService
.getWorkflowModificationEnabledStream()
.pipe(untilDestroyed(this))
- .subscribe(modifiable => (this.isWorkflowModifiable = modifiable));
+ .subscribe(modifiable => {
+ this.isWorkflowModifiable = modifiable;
+ // A generation started from the workflow dashboard has no canvas to
run on, so the
+ // dashboard defers it here: once this freshly created workflow is
loaded and editable,
+ // pick up the handoff and run the same pipeline the toolbar button
uses. consumePending-
+ // Generation guards by wid and clears on consume, so this fires once
for its workflow.
+ if (modifiable && this.pythonNotebookMigrationEnabled) {
+ const wid = this.workflowActionService.getWorkflowMetadata().wid;
+ if (wid !== undefined) {
+ const pending =
this.notebookMigrationService.consumePendingGeneration(wid);
Review Comment:
I have fixed in
[4d5db07](https://github.com/apache/texera/pull/7392/commits/4d5db075c06d00919e28aa9c2fe010c2b800ad28)
so that consumePendingGeneration now drops the slot on a wid mismatch too, so
a handoff that missed its target load cannot survive the SPA session and fire
on a later reopen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
