aglinxinyuan opened a new pull request, #7547:
URL: https://github.com/apache/texera/pull/7547

   ### What changes were proposed in this PR?
   
   The suite calls the handlers directly, which is not the same thing: coverage 
for `(click)="onClickX()"` lands on the generated listener body, so a button 
wired to the wrong handler — or to none — looks perfectly tested today.
   
   Adds 2 tests that click the real elements. The first is table-driven over 
six visually near-identical icon buttons, since a copy-paste leaving two of 
them on the same handler is the realistic defect. The second asserts the 
converse: clicking auto-layout must not also reset the panels.
   
   **Verified by mutation**, all reverted (template diff empty):
   
   | Mutation | Result |
   |---|---|
   | auto layout wired to reset panels | red |
   | close panels wired to reset panels | red |
   | generate report unwired | red |
   | reset zoom wired to auto layout | red |
   | add comment unwired | red |
   | reset panels wired to close panels | red |
   
   ### Deliberately not included
   
   The four display switches live in the `#executionSettings` popover, which 
ng-zorro instantiates into a CDK overlay only on open. Opening the first 
`NzPopoverDirective` on the page yields one switch, not four — locating the 
right one needs more overlay plumbing than four lines justify. They remain 
uncovered, and the issue records how to reach them.
   
   No production file is touched.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7546
   
   ### How was this PR tested?
   
   ```
   npx ng test --watch=false --include="**/menu.component.spec.ts"
   ```
   
   ```
    Test Files  1 passed (1)
         Tests  83 passed (83)
   ```
   
   2 new on top of the existing 81. `yarn format:ci` passes.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to