tanishqgandhi1908 commented on code in PR #6502:
URL: https://github.com/apache/texera/pull/6502#discussion_r3769951090
##########
common/workflow-core/src/main/scala/org/apache/texera/amber/core/storage/FileResolver.scala:
##########
@@ -88,23 +88,23 @@ object FileResolver {
val filePath = Paths.get(fileName)
val pathSegments = (0 until
filePath.getNameCount).map(filePath.getName(_).toString).toArray
- if (pathSegments.length < 4) {
+ if (pathSegments.length < 5 ||
!ResourceType.isValidPrefix(pathSegments(0))) {
Review Comment:
Valid observation, but this is pre-existing: Seq(localResolveFunc,
datasetResolveFunc) is unchanged from main, and triggering it needs a literal
/datasets/ directory on the worker filesystem. Keeping this PR scoped to the
prefix change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
