Xiao-zhen-Liu commented on code in PR #6729:
URL: https://github.com/apache/texera/pull/6729#discussion_r3771184668
##########
amber/src/main/scala/org/apache/texera/web/service/ExecutionStatsService.scala:
##########
@@ -124,7 +124,8 @@ class ExecutionStatsService(
metrics.operatorStatistics.numWorkers,
metrics.operatorStatistics.dataProcessingTime,
metrics.operatorStatistics.controlProcessingTime,
- metrics.operatorStatistics.idleTime
+ metrics.operatorStatistics.idleTime,
+ reusedFromCache = metrics.reusedFromCache
Review Comment:
Deleted the rebuild; computeStatsDiff now returns the combined map as is, so
the flag survives to the #5884 decision.
##########
amber/src/test/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/ExecutionUtilsSpec.scala:
##########
@@ -337,4 +339,27 @@ class ExecutionUtilsSpec extends AnyFlatSpec {
assert(result.operatorStatistics.numWorkers == 3)
assert(result.operatorStatistics.dataProcessingTime == 12)
}
+
+ // -- aggregateMetrics: reused-from-cache provenance ----------------------
+
+ it should "report reusedFromCache only when every physical operator is
reused" in {
+ val reusedA = metricsWith(WorkflowAggregatedState.COMPLETED, reused = true)
+ val reusedB = metricsWith(WorkflowAggregatedState.COMPLETED, reused = true)
+ val computed = metricsWith(WorkflowAggregatedState.COMPLETED)
+
+ assert(ExecutionUtils.aggregateMetrics(List(reusedA,
reusedB)).reusedFromCache)
+ assert(!ExecutionUtils.aggregateMetrics(List(reusedA,
computed)).reusedFromCache)
+ assert(!ExecutionUtils.aggregateMetrics(List(computed)).reusedFromCache)
+ }
+
+ it should "default reusedFromCache to false for empty input and untouched
metrics" in {
+ // Empty input takes the early-return path, whose default is false. This is
+ // the empty-cache property for the flag: nothing sets it until a producer
does.
Review Comment:
Applied your wording, and dropped the duplicate assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
