aglinxinyuan opened a new pull request, #7620:
URL: https://github.com/apache/texera/pull/7620

   ### What changes were proposed in this PR?
   
   Deletes `VirtualCollection` and its spec — an abstract class with no 
implementations and no call sites. Pure deletion, no behaviour change: **−198 
lines**.
   
   Nothing in the repository extends it. The storage layer's live abstractions 
are `VirtualDocument` and `ReadonlyVirtualDocument`, neither of which derives 
from it. With no subclass anywhere, no instance can exist, so none of its 
methods can run.
   
   > Reviewer note: its spec exercises a private stub defined inside the spec 
file itself, which is why the class currently looks live. That spec covers this 
class and nothing else, so it goes with it. `VirtualDocument` and 
`ReadonlyVirtualDocument` are untouched.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7617
   
   ### How was this PR tested?
   
   Existing tests only — this PR adds none, since it removes code and the spec 
that covered it.
   
   Locally, from the repo root with Java 17:
   
   - `sbt "WorkflowExecutionService/Test/compile"` — success (main and test 
sources).
   
   Verification, re-runnable by a reviewer:
   
   ```
   git grep -n VirtualCollection            # only the two deleted files
   git grep -n "extends VirtualCollection"  # no implementations
   ```
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to