eugenegujing opened a new issue, #7634:
URL: https://github.com/apache/texera/issues/7634

   ### What happened?
   
   `ComputingUnitManagingResourceSpec` reads a field called `ownerGoogleAvatar` 
in two assertions, but `DashboardWorkflowComputingUnit` declares it as 
`ownerAvatar` (`ComputingUnitManagingResource.scala:162`). The module's test 
sources therefore do not compile.
   
   Because Scala test compilation is per module, the impact is much wider than 
two assertions: **no test in `computing-unit-managing-service` can run at 
all.** `ComputingUnitHelpersSpec`, `AdminComputingUnitResourceSpec`, 
`KubernetesClientSpec` and `ComputingUnitAccessResourceSpec` are all taken down 
with it — 116 tests across 8 suites.
   
   A repo-wide grep for `ownerGoogleAvatar` over all `.scala` sources returns 
exactly the two lines in that spec (`:179` and `:285`). There is no alias, 
extension method, or second definition anywhere.
   
   #7563 renamed the field and correctly updated the two specs that referenced 
it at the time — `AdminComputingUnitResourceSpec` and 
`ComputingUnitHelpersSpec`, both of which use `ownerAvatar` on main today. 
`ComputingUnitManagingResourceSpec` had no avatar assertions then, so there was 
nothing to update. #7580 subsequently added them from a branch based before the 
rename, and its CI ran against that older base. 
   
   **Expected:** main compiles its test sources and the spec then passes 31/31 
unchanged.
   
   ### How to reproduce?
   
   1. Check out `main`.
   2. Run `sbt "ComputingUnitManagingService/Test/compile"`.
   3. Compilation fails with two `value ownerGoogleAvatar is not a member of 
...DashboardWorkflowComputingUnit` errors (full output in the log section 
below).
   
   Consequently `sbt "ComputingUnitManagingService/test"` cannot run any of the 
module's 116 tests.
   
   ### Version/Branch
   
   1.3.0-incubating-SNAPSHOT (main)
   
   ### Commit Hash (Optional)
   
   _No response_
   
   ### What browsers are you seeing the problem on?
   
   _No response_
   
   ### Relevant log output
   
   ```shell
   [error] 
/computing-unit-managing-service/src/test/scala/org/apache/texera/service/resource/ComputingUnitManagingResourceSpec.scala:179:10:
 value ownerGoogleAvatar is not a member of 
org.apache.texera.service.resource.ComputingUnitManagingResource.DashboardWorkflowComputingUnit
   [error]     info.ownerGoogleAvatar shouldBe "owner-avatar"
   [error]          ^
   [error] 
/computing-unit-managing-service/src/test/scala/org/apache/texera/service/resource/ComputingUnitManagingResourceSpec.scala:285:13:
 value ownerGoogleAvatar is not a member of 
org.apache.texera.service.resource.ComputingUnitManagingResource.DashboardWorkflowComputingUnit
   [error]     created.ownerGoogleAvatar shouldBe null
   [error]             ^
   [error] two errors found
   [error] (ComputingUnitManagingService / Test / compileIncremental) 
Compilation failed
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to