tanishqgandhi1908 commented on code in PR #6869: URL: https://github.com/apache/texera/pull/6869#discussion_r3779931517
########## common/workflow-core/src/main/scala/org/apache/texera/amber/core/storage/model/ModelFileDocument.scala: ########## Review Comment: Done. LakeFSFileDocument now takes the resource type and resolves its own presign endpoint, one unified document class serves every resource type. Just a note: DatasetFileDocument could go because its only remaining content was a clear() override deleting from the pre-LakeFS local git store at user-resources/datasets/0 (did hardcoded to 0, and the last production caller of GitVersionControlLocalFileStorage). Dataset files are only ever opened read-only, and the live .clear() callers all operate on Iceberg execution URIs, so it was unreachable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
