PG1204 commented on PR #7585: URL: https://github.com/apache/texera/pull/7585#issuecomment-5288235207
> LGTM. One thing worth a quick ack since it goes beyond what #7199 asked for: this also drops the prompt-column fallback for candidate labels, so any workflow still supplying labels through the prompt column will now fail with the config error instead. Given the fallback was a pre-#5574 transition shim and the error message points users to the right field, this seems fine. @xuang7 thanks! yep, deliberate. It makes zero-shot-image-classification consistent with text zero-shot-classification (labels come only from the candidate labels field), and the pre-loop check turns any prompt-column usage into a clear error instead of silently-wrong results. Agreed that it's fine to drop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
