aglinxinyuan commented on PR #7451: URL: https://github.com/apache/texera/pull/7451#issuecomment-5311063996
Thanks @Yicong-Huang — you're right, and the trace is exact. `git grep -n Xelide -- '*.sbt'` gives sixteen modules at `WARNING` (900), with all four wrappers below it (`FINEST` 300, `FINER` 400, `FINE` 500, `INFO` 800), so the elision was live the whole time. I grepped for `elidable` and never for `elide`, so I missed the flag. The description and #7448 now rest on the sufficient ground — no caller. `git grep -in elidable` is empty at the head, so nothing is left dangling. On the advisory: agreed. `amber/build.sbt` even carries a `// to turn on, use: INFO` comment that refers to nothing once this lands. Filed as #7706 rather than widening this PR, since it's sixteen build files. Noted there that `assert`/`assume` are `@elidable(ASSERTION)` = 2000, above `WARNING`, and scalac elides nothing when the flag is absent — so dropping it is a genuine no-op. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
