Yicong-Huang commented on code in PR #7586:
URL: https://github.com/apache/texera/pull/7586#discussion_r3794716108
##########
.github/workflows/build.yml:
##########
@@ -161,7 +161,19 @@ jobs:
- name: Install Playwright Chromium
run: yarn --cwd frontend playwright install ${{ matrix.os ==
'ubuntu-latest' && '--with-deps' || '' }} chromium
- name: Run frontend browser-mode tests
- run: yarn --cwd frontend ng run gui:test-browser
+ run: yarn --cwd frontend ng run gui:test-browser --coverage
--coverage-reporters=lcovonly
+ - name: Upload frontend browser-mode coverage to Codecov
+ # These tests already exercise code the jsdom run cannot reach
(Monaco, real
+ # pointer input); without this upload those lines are reported as
uncovered.
+ # vitest.browser.config.ts writes to coverage-browser/ so this does
not collide
+ # with the jsdom run's coverage/gui/lcov.info.
+ if: matrix.os == 'ubuntu-latest' && always()
+ uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f
# v7.0.0
+ with:
+ token: ${{ secrets.CODECOV_TOKEN }}
+ files: ./frontend/coverage-browser/**/lcov.info
Review Comment:
This glob does not match the flat `coverage-browser/lcov.info` output. The
current job succeeds only because Codecov falls back to a workspace search and
uploads the jsdom report again. Naming the artifact directly and disabling
fallback makes this step honor its intended input.
```suggestion
files: ./frontend/coverage-browser/lcov.info
disable_search: true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
