aglinxinyuan opened a new issue, #7779:
URL: https://github.com/apache/texera/issues/7779
### Task Summary
`ClientActor.ClosureRequest` is a message type that nothing ever sends — the
`case` arm handling it in `ClientActor.receive` is unreachable.
`AmberClient` is the only thing that messages `ClientActor`, and it sends
exactly two things: `PoisonPill` on shutdown and `CommandRequest` for RPC
calls. A repo-wide search for `ClosureRequest` returns only the
companion-object declaration, the import that pulls it into `ClientActor`, its
`receive` arm, and two tests.
The arm it removes is a run-arbitrary-closure-on-the-actor-thread escape
hatch:
```scala
case ClosureRequest(closure) =>
try sender() ! closure()
catch { case e: Throwable => sender() ! e }
```
Nothing in the engine uses that path today.
The two tests covering it came from the 2026 coverage work, which is why it
currently looks live. The spec's header comment explaining why it lives in
`...engine.common.client` (the members are `private[client]`) stays, reworded
to drop the `ClosureRequest` mention — the rationale still holds for
`ClientActor` itself.
Pure deletion, no behaviour change: −27 lines.
### Task Type
- [x] Refactor / Cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
