aglinxinyuan opened a new pull request, #7780:
URL: https://github.com/apache/texera/pull/7780

   ### What changes were proposed in this PR?
   
   Deletes the `ReportCurrentProcessingTuple` client event, which has neither a 
producer nor a consumer. Pure deletion, no behaviour change: **−42 lines**.
   
   Both sides of the channel were enumerated on current `main`:
   
   | Side | What exists | Includes this type? |
   | --- | --- | --- |
   | Producers | every `sendToClient(...)` argument in `amber/src/main` — 
`ExecutionStateUpdate`, `ExecutionStatsUpdate`, `FatalError`, 
`OperatorPortResultUriAvailable`, `RuntimeStatisticsPersist`, 
`UpdateExecutorCompleted`, `WorkerAssignmentUpdate`, `ConsoleMessage`, 
`EmptyReturn` | no |
   | Consumers | every `registerCallback[T]` — `ConsoleMessage`, 
`ExecutionStateUpdate`, `ExecutionStatsUpdate`, `FatalError`, 
`OperatorPortResultUriAvailable`, `RuntimeStatisticsPersist`, 
`UpdateExecutorCompleted`, `WorkerAssignmentUpdate`, `WorkflowRecoveryStatus` | 
no |
   
   `ClientActor` dispatches `ClientEvent`s through those `ClassTag`-keyed 
callbacks, so nothing can construct this event and nothing would receive it if 
something did.
   
   Removing it also frees the `core.tuple.Tuple` import in `ClientEvent.scala` 
— no other event in that file uses it. The `ClientEvent` trait and its nine 
live subtypes are untouched.
   
   > Reviewer note: the two round-trip serde tests it had came from the 2026 
coverage work, which is why it currently looks live. They cover this event and 
nothing else, so they go with it; the spec's other 15 tests are unchanged and 
still pass.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7778
   
   ### How was this PR tested?
   
   Existing tests only — this PR adds none, since it removes code and the tests 
that covered it.
   
   Locally, from the repo root with Java 17:
   
   - `sbt "WorkflowExecutionService/Test/compile"` — success.
   - `sbt "WorkflowExecutionService/testOnly *ClientEventSpec"` — 15 tests, all 
pass.
   - `sbt scalafmtCheckAll "scalafixAll --check"` — clean (this PR edits 
surviving files, so the unused-import gate matters).
   
   Verification, re-runnable by a reviewer:
   
   ```
   git grep -n ReportCurrentProcessingTuple    # only the deleted declaration 
and its tests
   git grep -ho 'registerCallback\[[A-Za-z]*\]' -- amber/src/main | sort -u   # 
no registration for it
   ```
   
   > CI note: build jobs may fail repo-wide at workflow startup while the 
injected `carabiner-dev/actions/install/ampel` action is off the ASF allowlist 
— `main` fails identically. Same class as #6989 and #7572, unrelated to this 
change.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to