mengw15 commented on code in PR #7754:
URL: https://github.com/apache/texera/pull/7754#discussion_r3817039971
##########
amber/src/main/scala/org/apache/texera/web/model/websocket/request/WorkflowExecuteRequest.scala:
##########
@@ -37,6 +37,8 @@ case class WorkflowExecuteRequest(
workflowSettings: WorkflowSettings,
emailNotificationEnabled: Boolean,
computingUnitId: Int,
- // The user_warehouse this run writes into; absent = the shared default
warehouse.
- warehouseId: Option[Int]
+ // The user_warehouse row this run writes into; absent = the shared default
+ // warehouse. Named `whid` after the column, so it is not read as
Lakekeeper's
+ // own warehouse id (a UUID).
+ whid: Option[Int]
Review Comment:
Reverted to `warehouseId` — you're right, `computingUnitId` right above is
the convention (column shorthand only at the jOOQ boundary). Lakekeeper's own
id keeps the `lakekeeperWarehouseId` name, so the bare word stays unambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
