zyratlo commented on code in PR #7741:
URL: https://github.com/apache/texera/pull/7741#discussion_r3817051177
##########
frontend/src/app/workspace/service/notebook-migration/notebook-migration.service.ts:
##########
@@ -163,6 +163,23 @@ export class NotebookMigrationService {
}
}
+ // Remove a workflow's notebook file from the Jupyter pod. Takes a concrete
wid so it can
+ // never fall back to the shared default filename and delete the wrong file;
callers guard
+ // out unsaved workflows before calling. Best effort by design: the database
rows are the
+ // source of truth for whether a workflow has a notebook, so a failure here
is logged, not
+ // surfaced, and nothing acts on the outcome.
+ public async deleteNotebookForWorkflow(wid: number): Promise<void> {
+ if (!this.enabled) return;
Review Comment:
fixed in
[b220820](https://github.com/apache/texera/pull/7741/commits/b220820de09a289348d2ed012716d24519e409eb)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
