zyratlo commented on PR #7791: URL: https://github.com/apache/texera/pull/7791#issuecomment-5349106846
This PR also folds in a small unrelated cleanup [effabc3](https://github.com/apache/texera/pull/7791/commits/effabc35574093474b113906d589d00145d9c67b): it removes the dead `JupyterPanelService.openPanel`. mengw15 flagged it (https://github.com/apache/texera/pull/7741#pullrequestreview-4977465264). The method lost its only production caller when #7571 removed the toolbar import branch, and its comment still described that flow, which no longer exists. Since this PR already touches `jupyter-panel.service.ts`, it was a convenient place to land the cleanup. The `jupyterNotebookExists` toolbar signal is still set on the normal path in `init()`, so no behavior is lost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
