mengw15 opened a new pull request, #8005:
URL: https://github.com/apache/texera/pull/8005
### What changes were proposed in this PR?
The three presentational pieces of the warehouse dashboard tab, each
mirroring its computing-unit counterpart. Second of three parts of #6933, on
top of the API client (#7820); nothing renders these yet — the page that
assembles them follows.
- **`warehouse-create-modal`** — embedded through `[(visible)]` and
returning its result through `(warehouseCreated)`, the same contract as
`ComputingUnitCreateModalComponent`. It disables Create on an empty name,
guards against double submission, stays open on failure so the name can be
corrected, and abandons its attempt when the dialog closes — so Cancel actually
cancels, and a late response cannot close a dialog the user has already
reopened.
- **`warehouse-metadata`** — the read-only details dialog the row name
opens: name, owner, flavor, created. The Lakekeeper catalog name is
deliberately absent; it locates data inside storage the user has no access to
until warehouses live in their own bucket (#6870, Phase 1).
- **`user-warehouse-list-item`** — the row card, matched to the
computing-unit row down to its 64px content height, hover-revealed delete, id
column and metadata columns. Warehouses have no status, metrics, rename or
sharing, so the computing-unit row's badge, progress bars, inline rename and
share control have no counterpart.
### Any related issues, documentation, discussions?
Part of #6933 (second of three: API client #7820, then these components,
then the page). Part of #6870; the on-canvas picker follows in #7817.
### How was this PR tested?
- Vitest specs for all three components: 20 tests across 3 files, covering
100% of the lines and branches this PR adds.
- Whole suite as CI runs it: `yarn test:ci`
- Just this change: `ng test --watch=false --include
"src/app/common/component/warehouse-*/**/*.spec.ts" --include
"src/app/dashboard/component/user/user-warehouse/**/*.spec.ts"`
- The dialog is driven through its own controls — the Create button, the
Cancel button, the Enter key and the text input — rather than by calling
component methods, so the template bindings are verified too.
- Failure paths verified rather than assumed: each behaviour was broken on
purpose and the suite confirmed to fail for the expected reason before being
restored.
- Exercised end to end against a local deployment with the flag on, backed
by live Lakekeeper and MinIO.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-opus-5, claude-fable-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
