Yicong-Huang commented on code in PR #7464: URL: https://github.com/apache/texera/pull/7464#discussion_r3870645733
########## sql/updates/42.sql: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +\c texera_db + +SET search_path TO texera_db; + +BEGIN; + +-- Remove the deprecated "project" feature (user projects: colour-tagged +-- collections of workflows, with sharing and public projects). See issue #5172. +-- +-- IRREVERSIBLE, USER-VISIBLE DATA LOSS: every project (name, description, +-- colour), every workflow-to-project assignment, every project access grant and +-- every public-project listing is deleted. Workflows, datasets and their own +-- access grants are untouched -- but a workflow that a user could previously +-- reach ONLY through a project share becomes inaccessible to that user, because +-- workflow access is now decided solely by workflow_user_access. Operators who +-- want to preserve those grants must copy them into workflow_user_access BEFORE +-- applying this migration. Review Comment: "Operators" collides with Texera's own vocabulary — an operator is a workflow node, not a person running a deployment. The audience of this warning is whoever applies the migration, so naming them explicitly avoids the ambiguity: ```suggestion -- workflow access is now decided solely by workflow_user_access. Deployment -- administrators who want to preserve those grants must copy them into -- workflow_user_access BEFORE applying this migration. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
