aglinxinyuan commented on code in PR #7464:
URL: https://github.com/apache/texera/pull/7464#discussion_r3870708924
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/SearchQueryBuilder.scala:
##########
@@ -39,12 +39,11 @@ object SearchQueryBuilder {
// DATASET_RESOURCE_TYPE aliases ResourceType.Dataset, whose value doubles
as the leading
// segment of a storage logical path, so renaming that prefix silently
changes search results
// with no compile error here.
- // TODO: give every resource type (file, workflow, project, dataset, model)
a single shared
+ // TODO: give every resource type (file, workflow, dataset, model) a single
shared
// constant/enum instead of these raw strings, so the search contract
has one source of
// truth and no longer borrows an unrelated storage constant.
val FILE_RESOURCE_TYPE = "file"
Review Comment:
Deleted `FILE_RESOURCE_TYPE` — confirmed it had exactly one occurrence in
the tree (its own declaration) — and dropped `file` from the adjacent TODO list
so the comment no longer names it either.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/DashboardResource.scala:
##########
@@ -54,15 +53,14 @@ object DashboardResource {
The following class describe the available params from the frontend for
full text search.
* @param user The authenticated user performing the search.
* @param keywords A list of search keywords. The API will return
resources that match any of these keywords.
- * @param resourceType The type of the resources to include in the
search results. Acceptable values are "workflow", "project", "file" and "" (for
all types).
+ * @param resourceType The type of the resources to include in the
search results. Acceptable values are "workflow", "file" and "" (for all types).
Review Comment:
Fixed both: the `@param resourceType` line now reads `"workflow"`,
`"dataset"` and `""`, and line 178 now reads "allows specifying".
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
