yangzhang75 commented on PR #8436:
URL: https://github.com/apache/texera/pull/8436#issuecomment-5553641662
@mengw15. Agreed on the principle, and I want the same end state. The catch
is that
these two are more than a type registration:
- The code box is not an inline field, it is a button that opens Monaco into
a
ViewContainerRef the workspace registers, keyed off the canvas's
highlighted
operator. The form has neither, so making it open here is a small feature
of
its own (its own editor host + a different operator-id source).
- The reorder list renders without its rows: it is a FieldArrayType whose row
template the panel builds with extra dynamic-schema wiring that the form's
plain toFieldConfig does not, so that is real array work, not the reorder
callback.
Your data point stands and is already handled: an exposed code key from an
older client or a hand-edited config still renders, through the same plain
fallback, so nothing is unhandled.
For the MVP I would keep both as clean fallbacks and add the real in-form
code
editor and drag list as a follow-up, so we do not hold these render PRs on
building two widgets into a host they were not made for. I will open a
follow-up issue to track it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
