aglinxinyuan opened a new pull request, #8464:
URL: https://github.com/apache/texera/pull/8464

   ### What changes were proposed in this PR?
   
   Deletes `DatasetVersionFileTreeManager`, which builds a client-side hash map 
of dataset file paths that nothing in production constructs. Pure deletion, no 
behaviour change: **−287 lines**.
   
   ### History
   
   | | |
   | --- | --- |
   | **Introduced by** | #2413 (2024-02-26) — "Introduce Dataset GUI" |
   | **Usage removed by** | #3296 (2025-03-10) — "Add FileService as a 
standalone microservice, LakeFS+S3 as dataset storage" deleted the real usages 
from `files-uploader.component.ts` (`previouslyUploadFilesManager`, 
`newUploadFileTreeManager`) once LakeFS began serving the file tree. The 
leftover dangling import was swept away by #3848 (2025-10-11, the `org.apache` 
rename) |
   
   Dead for about a year and a half.
   
   > Reviewer note: the rest of `datasetVersionFileTree.ts` stays — 
`DatasetFileNode` and `getFullPathFromDatasetFileNode` have live consumers, and 
the spec keeps its coverage of both. Only the class and its own `describe` 
block are removed.
   
   ### Any related issues, documentation, discussions?
   
   Closes #8462
   
   ### How was this PR tested?
   
   Existing tests only — this PR removes a class and the spec block that 
covered it.
   
   From `frontend/`:
   
   - `npx ng test --watch=false --include='**/datasetVersionFileTree.spec.ts'` 
— 10 tests pass (the surviving `DatasetFileNode` / 
`getFullPathFromDatasetFileNode` coverage).
   - `yarn --cwd frontend format:ci` — clean.
   
   Verification, re-runnable by a reviewer:
   
   ```
   git grep -n DatasetVersionFileTreeManager        # only the deleted class 
and its tests
   git grep -n getFullPathFromDatasetFileNode       # the live sibling, 
untouched
   ```
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to