Copilot commented on code in PR #8240:
URL: https://github.com/apache/texera/pull/8240#discussion_r3970134733
##########
amber/src/main/python/core/util/virtual_identity.py:
##########
@@ -111,6 +111,9 @@ def deserialize_global_port_identity(encoded_str: str) ->
GlobalPortIdentity:
port_id = int(port_id_str)
if port_id < 0:
raise ValueError(f"portId must be non-negative: {port_id}")
+ for field, value in (("isInternal", is_internal_str), ("isInput",
is_input_str)):
+ if value.lower() not in ("true", "false"):
+ raise ValueError(f"Invalid {field}: {value}")
Review Comment:
The error message omits context about what values are allowed. Consider
including the accepted values (e.g., \"expected true/false\") and/or the full
encoded string to make debugging easier when this occurs in production logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
