yangzhang75 commented on code in PR #8456:
URL: https://github.com/apache/texera/pull/8456#discussion_r3983041343
##########
frontend/src/app/workspace/component/property-editor/property-editor.component.ts:
##########
@@ -248,7 +276,11 @@ export class PropertyEditorComponent implements OnInit,
OnDestroy, OnChanges {
if (highlightedOperators.length === 1 && highlightLinks.length === 0
&& highlightedPorts.length === 0) {
this.currentComponent = OperatorPropertyEditFrameComponent;
- this.componentInputs = { currentOperatorId: highlightedOperators[0],
exposeChoosing: this.choosing };
+ this.componentInputs = {
+ currentOperatorId: highlightedOperators[0],
+ exposeChoosing: this.choosing,
+ broadcastEditing: this.broadcastEditing,
+ };
Review Comment:
Confirmed and fixed in the read-only inspect PR (#8442), where the input is
introduced. remountOperatorFrame spread the last componentInputs and refreshed
only exposeChoosing, so the rebuilt frame kept the mode it was leaving. That
mattered more after the rename in that PR: the frame re-reads actsAsEditor
before every write, so toggling Edit with a step already open would have
remounted the panel as a viewer and dropped the author edits silently. Two
changes: remountOperatorFrame now re-reads both mode inputs from the live
values, and ngOnChanges remounts on either of them rather than on
exposeChoosing alone, so the switch does not depend on the two happening to
flip together. Two tests, both checked to fail without the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
