yangzhang75 commented on code in PR #8455:
URL: https://github.com/apache/texera/pull/8455#discussion_r3984377787
##########
frontend/src/app/workspace/component/property-editor/property-editor.component.ts:
##########
@@ -205,6 +228,11 @@ export class PropertyEditorComponent implements OnInit,
OnDestroy, OnChanges {
@HostListener("window:beforeunload")
ngOnDestroy(): void {
+ // The Form View's read-only copy (persistPlacement=false) must not
persist geometry: it is not
+ // the docked canvas panel, so writing these keys would overwrite the real
panel's saved size.
+ if (!this.persistPlacement) {
+ return;
+ }
localStorage.setItem("right-panel-width", String(this.width));
localStorage.setItem("right-panel-height", String(this.height));
Review Comment:
Correction: #8442 merged before that push landed, so the change is in this
PR instead (same shape: the persistence block sits inside if
(this.persistPlacement), no early return).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
