kz930 opened a new pull request, #8509:
URL: https://github.com/apache/texera/pull/8509

   ### What changes were proposed in this PR?
   
   A visualization operator produces no table, so the table comparison has 
nothing to read. It writes a plotly figure and an HTML page, and this compares 
those.
   
   A chart's meaning is in the numbers behind it, so the comparison reads those 
rather than the rendered picture, which would fail over a layout detail that 
carries none. The figure is compared trace by trace.
   
   The page needs two things normalized away first, neither of which is markup 
the operator chose: a Styler id, which pandas regenerates on every run, and the 
line ending, which on Windows is CRLF for a file Python opened in text mode 
while the same markup carried through JSONL keeps the LF the engine wrote.
   
   Split out of #8359 on review. That change compares two tables, which is a 
different question and shares no code with this one.
   
   ### Any related issues, documentation, discussions?
   
   Part of #8325; that issue lists the set in order.
   
   Closes #8508, the task this change is the whole of.
   
   ### How was this PR tested?
   
   `VisualizationHtmlComparatorSpec` pins both normalizations: two pages 
differing only in a Styler id compare equal, and so do two differing only in 
line endings, while a page differing in the markup itself does not.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 5)
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to