aicam commented on code in PR #8542:
URL: https://github.com/apache/texera/pull/8542#discussion_r4007283695
##########
bin/k8s/templates/base/lakekeeper/lakekeeper-init-job.yaml:
##########
@@ -31,6 +31,48 @@ spec:
name: {{ .Release.Name }}-lakekeeper-init
spec:
restartPolicy: Never
+{{- if .Values.lakekeeperInit.createBucket }}
+ # Creates the Iceberg warehouse bucket before the warehouse is
registered.
+ # `rc` is RustFS's S3 client; using its image keeps the client out of the
+ # main container, which would otherwise have to fetch a binary at
runtime.
+ initContainers:
Review Comment:
This is a new job added to create a bucket. I am not sure if this is needed
because previously we did not create a bucket in MinIO so why this is now
needed? I think @mengw15 can chime in.
If you have already tested and everything worked on both K8s and docker
compose, then Im fine with it, we can just keep a record here and discuss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
