aicam commented on code in PR #6897:
URL: https://github.com/apache/texera/pull/6897#discussion_r4029211175
##########
amber/src/main/scala/org/apache/texera/web/service/ExecutionReconfigurationService.scala:
##########
@@ -90,7 +91,10 @@ class ExecutionReconfigurationService(
val reconfigurationId = UUID.randomUUID().toString
val updateExecutorRequests = reconfigurations.map {
- case (op, _) => UpdateExecutorRequest(op.id, op.opExecInitInfo)
+ case (op, _) =>
+ // An edited UDF may now name a repository, and its code already
refers to the mount.
+ ensureMounted(op.mountLocators)
Review Comment:
It can't be null: `PhysicalOp.mountLocators` is
`executionTimeBinding.map(_.mountLocators).getOrElse(Set.empty)`, so an
operator that names no resource returns an empty set, and the binding itself
always returns a Set. With an empty set, `ensureAllMounted` is
`locators.foreach(ensureMounted)`, so nothing happens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
