mengw15 commented on code in PR #8555:
URL: https://github.com/apache/texera/pull/8555#discussion_r4033708611
##########
bin/bootstrap-lakekeeper.sh:
##########
@@ -42,7 +42,7 @@
STORAGE_ICEBERG_CATALOG_REST_WAREHOUSE_NAME="${STORAGE_ICEBERG_CATALOG_REST_WARE
STORAGE_ICEBERG_CATALOG_REST_S3_BUCKET="${STORAGE_ICEBERG_CATALOG_REST_S3_BUCKET:-texera-iceberg}"
STORAGE_S3_REGION="${STORAGE_S3_REGION:-us-west-2}"
STORAGE_S3_ENDPOINT="${STORAGE_S3_ENDPOINT:-http://localhost:9000}";
-STORAGE_S3_AUTH_USERNAME="${STORAGE_S3_AUTH_USERNAME:-texera_minio}"
+STORAGE_S3_AUTH_USERNAME="${STORAGE_S3_AUTH_USERNAME:-texera_rustfs}"
Review Comment:
`docs/tutorials/guide-to-launch-lakekeeper.md` documents this script and
still quotes the old default. Line 84 there reads
```
STORAGE_S3_AUTH_USERNAME="${STORAGE_S3_AUTH_USERNAME:-texera_minio}"
```
so the tutorial now shows a value the script no longer uses, and line 99
still says the bucket is created "in MinIO". That file only exists on this
branch — it is not in `main` — so #8542 had nothing to sweep there and this is
the one place the backport has more surface than the original.
Everything else lines up: I diffed the two file sets and the 14 paths #8542
touches that this one doesn't are either the same file at v1.2's flatter chart
paths or files that don't exist on the branch, and the two that do exist
(`main_loop.py`, `S3StorageClientSpec.scala`) were comment-only over there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
