yangzhang75 opened a new pull request, #8579:
URL: https://github.com/apache/texera/pull/8579
### What changes were proposed in this PR?
Two places outside the share dialog have to agree with the pin, and then the
feature is complete.
- **The versions panel marks the version the Hub is serving**, as a quiet
second line under its
timestamp rather than a tag: the panel is 230px wide, so horizontal room
is scarce while
vertical room is free. That row is also how an author who has moved on
gets the published copy
back — it is already in the panel, so restoring it is the restore they
already know. The panel
re-reads when the share dialog closes, since that is where the pin can
have moved and the panel
is covered until then.
- **Hub entries open what they advertise.** A hub card shows the public
copy, so an author whose
working copy has moved on behind a pin now lands on the published preview
— what they just saw,
and where Clone gives them a copy of it — rather than in their editor
showing something else.
Their own listings are untouched: there the entry is their workflow.
- **The flag goes on.** `gui.workflow-workspace.version-pinning-enabled`
flips to `true`, which is
what makes the switch appear in the share dialog. It is deliberately the
last change of the
series: every surface that has to agree with a pin is in place by the time
an author can make
one. Nothing downstream needed its own gate — a listing marker and a hub
link both depend on a
pin existing, and no pin can exist while the control is hidden.
### Any related issues, documentation, discussions?
Closes #7943
Part of #7828. Design discussion: #7128. Stacked on #7853, #8575, #8576,
#8577 and #8578; until
those merge this PR shows their commits too, and the review here is the last
one.
**This is the PR that turns the feature on.** It should merge last.
### How was this PR tested?
Frontend: the versions-list spec covers the marker appearing only on the
version the Hub serves
and the panel re-reading when the announcement comes; the menu spec covers
the announcement being
made when the share dialog closes, and not when the user has just revoked
their own access and is
being navigated away; the registry spec covers the routing rule — a hub
entry whose public copy
is behind goes to the preview, one that is not goes to the editor, and a
private-search row is
never diverted; the card and list specs cover the argument reaching the
rule. Full suite passes
(5989), production (AOT) build passes, prettier clean.
Backend: `GuiConfigSpec` now pins the flag's default to on (72 tests); the
dashboard package
passes (567); scalafmt clean.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
