Copilot commented on code in PR #8586:
URL: https://github.com/apache/texera/pull/8586#discussion_r4044207990
##########
frontend/src/app/workspace/service/agent/agent.service.ts:
##########
@@ -666,6 +668,12 @@ export class AgentService {
if (selectedUnit) {
body.computingUnitId = selectedUnit.computingUnit.cuid;
}
+ // Same for the warehouse the user picked: agent runs write into it
rather than
+ // shared storage, which the backend requires while the feature is on
(#7751).
+ const selectedWarehouseId =
this.warehouseService.getSelectedWarehouseIdValue();
+ if (selectedWarehouseId !== undefined) {
+ body.warehouseId = selectedWarehouseId;
Review Comment:
`warehouseId` is dropped at the next hop. The agent API handler still
destructures only `modelType`, `name`, `workflowId`, `computingUnitId`, and
`settings` (`agent-service/src/server.ts:178`), and both
`CreateAgentRequest`/`AgentDelegateConfig` and the `setDelegateConfig` call
omit this field. Consequently `TexeraAgent.buildExecutionConfig()` always
receives `undefined`, so feature-enabled agent executions are rejected instead
of using the selected warehouse. Please carry the value through the request
type, handler, delegate config, and `setDelegateConfig`, and cover the
end-to-end forwarding in the agent-service tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
