Copilot commented on code in PR #8535:
URL: https://github.com/apache/texera/pull/8535#discussion_r4060060797
##########
amber/src/test/scala/org/apache/texera/amber/engine/architecture/scheduling/WorkflowExecutionManagerSpec.scala:
##########
@@ -150,6 +150,41 @@ class WorkflowExecutionManagerSpec
assert(rpcProbe.startedWorkers.contains(secondWorkerId))
}
+ it should "run workflow-completion cleanup exactly once after the workflow
becomes terminal" in {
+ val workflowExecution = WorkflowExecution()
+ workflowExecution.initRegionExecution(jumpRegion(1, "completed"))
Review Comment:
This does not reproduce the ordering that caused #7032: `jumpRegion` has no
ports, so its `RegionExecution` is immediately complete and this manager never
owns a `RegionExecutionManager`. The callback could regress to running before
worker termination and this test would still pass. Please use a real
single-worker region with a pending `EndWorker`, assert cleanup is still zero
while termination is pending, then fulfill termination and assert it runs once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
