aglinxinyuan opened a new issue, #8676:
URL: https://github.com/apache/texera/issues/8676
### Task Summary
When a PR closes an issue that someone else has already claimed, post a
warning on it. Also stop the merge-time credit step from unassigning a claimant
whose own PR is still open.
**What happened.** A first-time contributor claimed #8149 with `/take` and
opened #8267 with the fix. Two days later, the bundled PR #8339 also wrote
`Closes #8149` and carried the same change. Nothing flagged the overlap, and
#8339 merged first. The "Credit issue assignees on PR merge" step in
`pr-assignment.yml` then removed the contributor from #8149's assignees. #8267
was left open with 0 changed files.
```
Before: #8267 open ── #8339 "Closes #8149" ── (silence) ── #8339 merges ──
claimant unassigned, #8267 empty
After: #8267 open ── #8339 "Closes #8149" ── comment on #8339 naming the
claimant + #8267
── #8339 merges ── claimant
stays assigned while #8267 is open
```
**Proposed**, all in `.github/workflows/pr-assignment.yml`:
| When | Change |
| --- | --- |
| PR opened / edited | For each open same-repo issue in
`closingIssuesReferences`, flag it when **(a)** it has an assignee other than
the PR opener, or **(b)** its `closedByPullRequestsReferences` lists another
open PR by a different author. Post or update one marker comment naming the
claimant and their PR. Delete the comment once nothing matches. |
| PR merged (credit step) | Keep an assignee who has their own open PR on
the issue. If that PR later closes unmerged, the existing close-without-merge
step still unassigns them. |
(b) is needed on its own. GitHub silently drops the opener self-assign for
outside contributors who never commented on the issue. For example, #6674 has
no assignee but has the open PR #8603, so (a) alone misses it.
The warning is a comment, not a failing check. Both PRs match the rule, so a
failing check would also go red on the claimant's own PR. Only a person can
tell an agreed takeover from a duplicate.
### Task Type
- [ ] Refactor / Cleanup
- [x] DevOps / Deployment / CI
- [ ] Testing / QA
- [ ] Documentation
- [ ] Performance
- [ ] Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
