Re: [PR] fix(amber, frontend): inline Hugging Face audio uploads as data URLs instead of a server temp file [texera]

Mon, 28 Sep 2026 09:37:31 -0700 


PG1204 commented on PR #7790:
URL: https://github.com/apache/texera/pull/7790#issuecomment-5874347633

   > @PG1204, ty for applying fixes and responding to the review. Since none of 
the issues were blocking, I approved this PR 2 weeks ago.
   > 
   > <img alt="Image" width="1537" height="254" 
src="https://private-user-images.githubusercontent.com/182038479/660364037-1b2aef84-406f-427c-8722-4c9e028771d1.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTA2MTM2MDQsIm5iZiI6MTc5MDYxMzMwNCwicGF0aCI6Ii8xODIwMzg0NzkvNjYwMzY0MDM3LTFiMmFlZjg0LTQwNmYtNDI3Yy04NzIyLTRjOWUwMjg3NzFkMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwOTI4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDkyOFQxNjM1MDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yYTJjYTEyMjg1NzU4ODBkZjgwOTZmYWI2NTZkMjZmNmQ0ZjJiYmQ2ODY1NzE0MDQzNWVhZWZjZGJkM2JiNjgzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.FjZ9gNerT3d3bEEQzX8fcEigy3BnH-EgaalYfcPYxM4";>
   > I approved it again now. Overall, it LGTM! I don't think we need a long 
discussion; they were minor issues, and I trust your discretion.
   
   @Ma77Ball Thanks for the review and approval.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to