aglinxinyuan opened a new pull request, #8746: URL: https://github.com/apache/texera/pull/8746
### What changes were proposed in this PR? Removes dead code from `DatasetDetailComponent` that its template stopped using during the dataset page's redesigns. **+2/−46 lines.** There is no behaviour change. - **Members:** `versionCreatorBaseVersion`, `displayPreciseViewCount` + `changeViewDisplayStyle()`, and the `formatTime` / `formatSpeed` aliases. The `format.util` import narrows to `formatCount`. - **Styles:** `.tag-settings-btn`, `.tag-settings-title`, `.tag-settings-row` (with its `span` and `::ng-deep .ant-switch` rules), and `.description-section`. - **Spec:** the "view flags" case keeps its maximize / right-bar assertions and drops the three for the removed toggle. It is renamed to match. ### History | | | | --- | --- | | **Introduced by** | #2413 (2024-02-26), "Introduce Dataset GUI": `versionCreatorBaseVersion`. #3269 (2025-02-19): the precise-view-count toggle. #3662 (2025-08-19): the speed/time aliases. #4337 (2026-03-29), "improve dataset detail page layout": the `.tag-settings-*` and `.description-section` styles | | **Usage removed by** | #3296 (2025-03-10): `versionCreatorBaseVersion`. #4337 (2026-03-29): the view-count toggle. #6493 (2026-07-27): tag settings moved to a Settings tab. #7043 (2026-07-30): the description moved to the Data Card tab. #8078 (2026-08-31): the speed/time aliases | Each piece was left behind by a redesign that moved its markup elsewhere. The oldest has been dead for eighteen months. ### Any related issues, documentation, discussions? Closes #8745 ### How was this PR tested? No new tests. The kept spec cases cover the remaining members. From `frontend/`: - `npx ng test --watch=false --include='**/dataset-detail.component.spec.ts'`: 150 tests, all pass. - `yarn format:ci`: clean. - `npx ng build`: success. To re-check: ``` git grep -n -E "versionCreatorBaseVersion|tag-settings|description-section" -- frontend # no hits ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
