aglinxinyuan opened a new pull request, #8748:
URL: https://github.com/apache/texera/pull/8748
### What changes were proposed in this PR?
Removes two leftovers from `HubWorkflowDetailComponent`. **−17 lines.**
There is no behaviour change.
- **Template:** the empty `<ng-template #codeEditor></ng-template>`. Nothing
reads it: the component has no `@ViewChild`, and the only other `#codeEditor`
in the app is the live one in `workspace.component.html`.
- **Styles:** the `.workflow-steps`, `.workflow-step`, `.workflow-step h3`
and `.workflow-step p` rules, which no markup uses.
### History
| | |
| --- | --- |
| **Introduced by** | #2725 (2024-09-24), "Add Hub": the step styles. #2873
(2024-09-27), "Add workflow preview to hub details page": the `#codeEditor`
anchor |
| **Usage removed by** | #3006 (2024-11-05), "Remove home page and step from
the detail page": the step markup. #3007 (2024-11-05), "Fix sharing issue of
hub preview": the `@ViewChild("codeEditor")` that read the anchor |
Both have been dead for nearly two years.
### Any related issues, documentation, discussions?
Closes #8747
### How was this PR tested?
No new tests.
From `frontend/`:
- `npx ng test --watch=false
--include='**/hub-workflow-detail.component.spec.ts'
--include='**/card-item.component.spec.ts'
--include='**/list-item.component.spec.ts'
--include='**/workspace.component.spec.ts'`: 4 files, 221 tests, all pass. The
card-item and list-item specs open this component in a modal, and the workspace
spec owns the live `#codeEditor`.
- `yarn format:ci`: clean.
- `npx ng build`: success.
To re-check:
```
git grep -n "workflow-step" -- frontend # no hits
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
