aglinxinyuan opened a new pull request, #8815:
URL: https://github.com/apache/texera/pull/8815
### What changes were proposed in this PR?
Deletes `amber/src/main/resources/cache.ccf`, an Apache Commons JCS cache
configuration that nothing loads. **−29 lines.** There is no behaviour change.
The `commons-jcs3-core` dependency stays, because `ComputingUnitMaster` /
`ComputingUnitWorker` still import its `InvalidArgumentException`.
JCS never names this file in code: it loads `/cache.ccf` from the classpath
implicitly, when the cache manager creates its first region. So the check for
this PR is whether anything can create a JCS cache, not whether the file name
appears anywhere. Nothing can:
- **Source:** the only JCS class referenced in any module is
`InvalidArgumentException`. Nothing calls `JCS.getInstance`, `CacheAccess`,
`CompositeCacheManager` or `JCSWorker`.
- **Bytecode:** after compiling amber and the common modules, the compiled
classes reference the same single exception class and no other JCS class.
- **Dependencies:** no other jar on amber's runtime or test classpath
references JCS.
`InvalidArgumentException` is a plain `RuntimeException` subclass with no
static initializer, so throwing it never reaches the cache manager.
### History
| | |
| --- | --- |
| **Introduced by** | #1328 (2021-09-08), "[Operator Caching Step 3] add
operator cache backend new files and config changes", for
`JCSOpResultStorage`'s `JCS.getInstance("texera")` |
| **Usage removed by** | #1363 (2022-01-25), "Sink operator result storage
abstraction and refactoring". It deleted `JCSOpResultStorage`, the only code
that ever created a JCS cache |
It has been dead for over four and a half years.
### Any related issues, documentation, discussions?
Closes #8814
### How was this PR tested?
No new tests; this deletes a resource file that nothing loads.
Locally, from the repo root with Java 17:
- `sbt "WorkflowExecutionService/Test/compile"`: success.
To re-check:
```
git grep -n -i "cache\.ccf\|JCS\.getInstance\|CompositeCacheManager" # no
hits
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
