aglinxinyuan opened a new issue, #8816:
URL: https://github.com/apache/texera/issues/8816

   ### Task Summary
   
   `UserConfigService` has a private `dictionaryChangedSubject` that it calls 
`.next()` on from `updateEntry` and `updateDict`. Nothing has ever subscribed 
to it.
   
   **Introduced by** #1162 (2021-06-27, "Add UserDictionaryService (User 
Presets Step 2)"). The Subject was private from the start, with no getter or 
`asObservable()`. Later commits only moved and renamed the file.
   
   **Usage removed by:** never used. The only readers are four spec cases that 
reach the private field through `(service as any)`.
   
   This is a pure deletion with no behaviour change: `updateEntry` / 
`updateDict` keep every guard, delete and assignment; only the `.next()` lines 
go.
   
   ### Task Type
   
   - [x] Refactor / Cleanup
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to