Copilot commented on code in PR #8843:
URL: https://github.com/apache/texera/pull/8843#discussion_r4199433364
##########
frontend/src/app/workspace/component/workflow-form/workflow-form.component.spec.ts:
##########
@@ -954,6 +954,22 @@ describe("WorkflowFormComponent", () => {
expect(component.rendered[0].fields[0].type).toBe("huggingface");
});
+ // Projection's column list is the drag-reorder widget on the canvas; the
form renders the same
+ // widget, drag and keyboard path included, rather than falling back to a
plain list (#8761).
Review Comment:
This comment promises a keyboard reorder path that this widget does not
provide; its template has only the pointer-driven CDK handle plus add/remove
buttons. Since the earlier review thread explicitly defers keyboard reordering,
describe only the drag behavior here.
##########
frontend/src/app/workspace/util/custom-formly-type.spec.ts:
##########
@@ -28,10 +28,10 @@ describe("NON_FORM_FIELD_TYPES", () => {
});
describe("CANVAS_ONLY_FORMLY_TYPES", () => {
- it("holds the widgets the form falls back from: the code editor and the
drag-reorder list", () => {
+ it("holds the widgets the form falls back from: the code editor, and the
code editor only", () => {
expect(CANVAS_ONLY_FORMLY_TYPES.has("codearea")).toBe(true);
- // the drag has nowhere to attach on a form, so an exposed one degrades to
the default control
- expect(CANVAS_ONLY_FORMLY_TYPES.has("repeat-section-dnd")).toBe(true);
+ // the drag-reorder list carries its own drop list, so the form renders
it, drag and all (#8761)
+ expect(CANVAS_ONLY_FORMLY_TYPES.has("repeat-section-dnd")).toBe(false);
Review Comment:
This updated assertion now conflicts with the earlier comment in the same
file, which still says the property renders without dragging. Update that
comment so the test documents the new behavior consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
