aglinxinyuan commented on PR #8678: URL: https://github.com/apache/texera/pull/8678#issuecomment-6031637521
@kunwp1 Thanks! The last Copilot finding, about stale overlapping runs overwriting the current state, is fixed in 90d1a3d1ea. The step already queried the PR live rather than using the event payload, so a delayed run did read up-to-date state when it started. The gap was the time between that read and its write. If an edit and a newer run both finished inside that window, the older run could then post a warning the newer run had just removed, or write old text over the newer comment. The step now goes through `syncClaimComment` in `issue-claims.js`. After any write it reads the PR again and repeats until a pass changes nothing, with at most 3 passes. The PR only changes on an edit, so the run that writes last also reads last, after every edit, and corrects its own stale write. It still never posts twice in one run, even if the re-list lags behind its own comment. Two new tests replay that interleaving: a delayed run posting after a newer run removed the warning, and a delayed run overwriting a newer run's text. Both fail if `syncClaimComment` is limited to one pass. `test_issue_claims.sh` now runs 42 tests, all passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
