PG1204 commented on issue #5726: URL: https://github.com/apache/texera/issues/5726#issuecomment-6053858422
> Sorry for the slow reply. In the [#6927](https://github.com/apache/texera/pull/6927) review I said I'd re-scope this issue myself, and I never did. > > Closing this as done. The problem it was opened for is fixed: [#5146](https://github.com/apache/texera/pull/5146) moved the border color decision into one function, [#5702](https://github.com/apache/texera/pull/5702) and [#6075](https://github.com/apache/texera/pull/6075) made every caller pass in the validation result, and [#6927](https://github.com/apache/texera/pull/6927) made a repeated border write with the same color cheap. > > I'd leave the double `validateOperator` call alone. For the add handler to reuse the service's result, it would have to count on the service validating first, which means depending on the order the two subscribers run in. That order is exactly what this issue's description got wrong (validation paints first, the add handler last), so I'd rather not build on it. The second call only redoes a check and changes nothing on screen, so it isn't worth that coupling. No need for the timing or a follow-up issue unless validation shows up in a profile later. > > Thanks for seeing this through four PRs. @Xiao-zhen-Liu Thanks for closing this issue out, and for the clear reasoning on the double validateOperator call. Agreed that reusing the service's result would mean depending on subscriber order, which is the exact thing this issue's description got wrong, so leaving it is the right call. Thanks for the reviews across all four PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
