Copilot commented on code in PR #8883:
URL: https://github.com/apache/texera/pull/8883#discussion_r4239318833
##########
frontend/src/app/dashboard/component/user/version-uploader/version-uploader.component.html:
##########
@@ -161,11 +161,17 @@
(keydown.enter)="onClickCreateVersion()"
class="version-input" />
</div>
+ <div
+ *ngIf="versionNameHasSlash"
+ class="version-name-error">
+ A version description cannot contain '/'.
+ </div>
Review Comment:
The new validation error is only visual: it is neither associated with the
input nor announced when it appears, so screen-reader users may encounter a
disabled Submit button without learning why. Mark the input invalid, connect it
to the message with `aria-describedby`, and expose the dynamic message as an
alert.
##########
frontend/src/app/dashboard/component/user/version-uploader/version-uploader.component.html:
##########
@@ -161,11 +161,17 @@
(keydown.enter)="onClickCreateVersion()"
class="version-input" />
</div>
+ <div
+ *ngIf="versionNameHasSlash"
+ class="version-name-error">
+ A version description cannot contain '/'.
+ </div>
<div>
<button
nz-button
nzType="primary"
[nzLoading]="isCreatingVersion"
+ [disabled]="versionNameHasSlash"
(click)="onClickCreateVersion()"
Review Comment:
This changes the interactive Submit/Enter flow, but the PR's test section
lists only automated commands and does not include the required manual click
path, browser, and viewport details (AGENTS.md:231-234). Please add those
verification details to the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
